[GSOC-46] Fuel model usage and migration to ROS 2 launch files#2
Conversation
|
|
||
| 1. Set the resource path to your local model files: | ||
| ```bash | ||
| export GZ_SIM_RESOURCE_PATH=<Path-to-dave_ws>/src/dave/dave_model_description |
There was a problem hiding this comment.
gazebosim/ros_gz#492 Could you try this to get rid of this step?
There was a problem hiding this comment.
I've no experience with hooks but it seems it's another alternative
Reference: https://github.com/gazebosim/ros_gz/tree/ros2/ros_gz_sim_demos
Also... hard to ask, but with best wishes, it seems ros_gz's demo is now all in python. What do you think of working with python from this and now on? With power of chatgpt
There was a problem hiding this comment.
All other parts worked fine! Thank you so much for investigating the previous dave structure and attempt to follow how it was done 👍
There was a problem hiding this comment.
Sure thing, I'll make those changes!
|
@woensug-choi, I've incorporated your comments into the commit. |
There was a problem hiding this comment.
So QUICK! Amazing..! 👍
-
no need
_bare_modelfor bare model. Will add_somethingas we add plugins or attachments (e.g. arms) -
I've treid universal
upload_model.launch.pyandmodel_in_empty_world.launchat https://github.com/IOES-Lab/dave/tree/fuel-models-universal.
ros2 launch dave_demos model_in_empty_world.py model_name:='nortek_dvl500_300'
ros2 launch dave_demos model_in_empty_world.py model_name:='mossy_cinder_block'I think you can use git merge fuel-models-universal on your PR if things look ok (please test! and make mods if necessary). I haven't modified README for demos. you may commit on top of fuel-models-universal and merge to your PR.
-
Any idea why gazebosim/ros_gz#492 didn't work? maybe it's not on release yet? added note on
package.xmlatdave_model_description -
There was a typo error at README.
cd <path-to-dave_ws>/src/dave_model_description->cd <path-to-dave_ws>/src/dave/dave_model_description
|
Awesome, thank you so for the quick and detailed review! I like the idea of just using one universal launch file! I have merged the branch after making minor mods. Any idea why gazebosim/ros_gz#492 didn't work? maybe it's not on release yet?
|
woensug-choi
left a comment
woensug-choi
left a comment
There was a problem hiding this comment.
Great! Our first PR! Thank you!!! 👍
Take pleasure to push merge button
woensug-choi
changed the title
woensug-choi
changed the title
2 participants
This PR introduces two features:
Fuel Model Integration Examples: We've added comprehensive examples demonstrating how to utilize models from Fuel, making it easier to incorporate these models into your projects.
ROS 2 Launch File Migration: Launch files have been updated to ROS 2, ensuring compatibility with the latest ROS version.